Refactoring code in src/meta/configs.js #585
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pull Request Test Coverage Report for Build 10731238995Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue, resolves #465
Instruction: Refactor this function to reduce its Cognitive Complexity from 19 to the 15 allowed. (lines 19-54 for deserialize(config) function).
Original:
Cognitive Complexity of 19
Edited:
Cognitive Complexity of 7
To trigger the function:
The functions defined in configs.js are utility functions that aid with type conversions and validations for configuration settings. Hence, they are automatically called during the setup/ initialization phase of NodeBB (after running ./nodebb start and ./nodebb log) to ensure that the configuration values are correctly interpreted and validated. So, it is automatic and does not need to be triggered.