refactor Flags.validate in src/flags.js #334
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tu2463
force-pushed
the
feat/refactor-FlagsValidate
branch
from
5d5b2ab
to
0dffb18
Compare
Pull Request Test Coverage Report for Build 10730752978Details
💛 - Coveralls |
tu2463
force-pushed
the
feat/refactor-FlagsValidate
branch
from
82a0585
to
ecfe1ae
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor Flags.validate in src/flag.js to reduce its Cognitive Complexity by adding a helper function 'checkSelfFlagError' to replace a nested function and a optional chaining to remove unnecessary checks.
Also added test cases for the refactored code.
Related Issue
Resolves #333