forked from cuttle-cards/cuttle
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modified the GameListItem.vue component to render the players' usernames in the home page list of games #1103 #3
Open
AlAnoud2003
wants to merge
9
commits into
main
Choose a base branch
from
issue1103FrontEnd
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed property called playersTextto generate correct player text, and updated template to use playersText to display the usernames
…to ensure the correct displaying of usernames based on the player count
…o test the rendering of the correct player information
…th the same variable
…layers' usernames, and then verifying that the game list item containes the text (the usernames)
AlAnoud2003
changed the title
Modified the GameListItem.vue component to render the players' usernames in the home page list of games #1128
Modified the GameListItem.vue component to render the players' usernames in the home page list of games #1103
Dec 12, 2024
Hakaabi
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job on this modification! looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number
Relevant issue number
Please check the following
Please describe additional details for testing this change
This pull request updates the GameListItem.vue component file in the frontend to ensure that it expects the game to have an array of players and that on the home page's list of open games, it renders text displaying who specifically is in the game (players' usernames) based on the number of players in the game.
In GameListItem.vue:
Testing: