Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converted /src/controllers/home.js from JS to TS #89

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

mahasultan
Copy link

This pull request shows the translation of the file src/controllers/home.js from javacript to typescript. This PR is in response to issue #38. This process involved the translation, creation of type interfaces for configuration and user settings objects to provide type safety, as well as Introduced try-catch blocks for improved error handling during URL parsing. I also made use of the ' eslint-disable-next-line @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-unsafe-call' feature to ensure I could use existing modules that have yet to be translated.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6025474426

  • 52 of 59 (88.14%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 84.963%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/controllers/home.js 52 59 88.14%
Files with Coverage Reduction New Missed Lines %
src/messaging/notifications.js 1 94.83%
src/database/mongo/hash.js 2 88.07%
Totals Coverage Status
Change from base Build 5912059056: -0.02%
Covered Lines: 22624
Relevant Lines: 25383

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants