Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOREF: Replace docker-compose with docker compose #2735

Merged
merged 8 commits into from
Aug 2, 2024

Conversation

Jdwoodson
Copy link
Contributor

@Jdwoodson Jdwoodson commented Aug 1, 2024

NOREF

Description

Docker Compose uses docker compose as the command, and docker-compose is the standalone plugin command as of Compose V2.

It appears that some Github Actions runners are missing the standalone plugin version, which causes issues when running the docker-compose command. This change will simplify and consolidate all Docker Compose actions to using docker compose

actions/runner-images#9692

Confirmed V1 is removed as of July 29.

How to test this change

PR Author Checklist

  • I have provided a detailed description of the changes in this PR.
  • I have provided clear instructions on how to test the changes in this PR.
  • I have updated tests or written new tests as appropriate in this PR.

PR Reviewer Guidelines

  • It's best to pull the branch locally and test it, rather than just looking at the code online!
  • When approving a PR, provide a reason why you're approving it
    • e.g. "Approving because I tested it locally and all functionality works as expected"
    • e.g. "Approving because the change is simple and matches the Figma design"
  • Don't be afraid to leave comments or ask questions, especially if you don't understand why something was done! (This is often a great time to suggest code comments or documentation updates)
  • Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.

@Jdwoodson Jdwoodson self-assigned this Aug 1, 2024
@Jdwoodson Jdwoodson added the github_actions Pull requests that update Github_actions code label Aug 1, 2024
samoddball
samoddball previously approved these changes Aug 1, 2024
@ClayBenson94 ClayBenson94 marked this pull request as ready for review August 2, 2024 13:37
@ClayBenson94 ClayBenson94 requested a review from a team as a code owner August 2, 2024 13:37
@ClayBenson94 ClayBenson94 requested review from adamodd and removed request for a team August 2, 2024 13:37
@ClayBenson94 ClayBenson94 merged commit a82169f into main Aug 2, 2024
13 checks passed
@ClayBenson94 ClayBenson94 deleted the NOREF/migrate-docker-compose-command branch August 2, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update Github_actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants