Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transport in one grid cell wide channels. #868

Closed
JFLemieux73 opened this issue Sep 15, 2023 · 13 comments
Closed

Transport in one grid cell wide channels. #868

JFLemieux73 opened this issue Sep 15, 2023 · 13 comments
Assignees
Labels

Comments

@JFLemieux73
Copy link
Contributor

@apcraig I will start modifying the remapping code to get transport in one grid cell wide channels. Would have time to implement a new test case? I think the best way to test this would be a east-west one grid cell wide channel maybe 200 km long. The initial ice conditions would be:

aice=0.5
thickness = 1 m
there is ice only between 10 and 60 km (a 50 km long block of ice).
There could be walls on both sides (at 0 km and 200 km).

The wind blows from the west at 5 m/s. We can then look at the ice fields after a few days...The block should be advected.

note: it would be nice also to have a south-north channel to make sure we get the same thing.

@JFLemieux73
Copy link
Contributor Author

12 lines of code...that's what was needed!

I coded a simple test case. Here is the initial condition (hi):

ic

@JFLemieux73
Copy link
Contributor Author

Here is the hi field after 20 days with upwind:

Upwind_hi_2005-01-20

and now with remap:

Remap_hi_2005-01-20

@JFLemieux73
Copy link
Contributor Author

So there is transport with remap (thanks to l_fixed_area = T). The solution is also a lot less diffused than the upwind one...good!

@dabail10
Copy link
Contributor

Wow. So, the incremental remapping does not just reduce to upwind in a situation like this? Great news.

@apcraig
Copy link
Contributor

apcraig commented Sep 17, 2023

Glad it was easy to setup and test. What's the next step? Do we want to formally commit the 1-grid channel grid to the code and setup a test in the test suite? Should we have a look at what the boxislands test is doing?

@JFLemieux73
Copy link
Contributor Author

I created the test a bit quickly. For example the box is 80x80...Let me clean it up before I commit it. I also think it would be good to test a north-south channel. I don't think we need the boxislands test case right now.

@apcraig
Copy link
Contributor

apcraig commented Sep 18, 2023

@JFLemieux73, if you want me to create a PR, I can also do that. I would also add a N-S channel case and add tests to the test suite and update documentation where needed. I'll also have a quick look at the boxislands test just for my own sanity.

@JFLemieux73
Copy link
Contributor Author

Yes maybe it is better (and faster) if you create the test cases. Should I first create a PR with my modifs to ice_transport_remap?

@apcraig
Copy link
Contributor

apcraig commented Sep 18, 2023

Just to be clear, to get transport in the channel, we need to modify the code??

If the problem is just very stiff, why don't we get some small non-zero transport? Why is it zero in the channel by default?

@JFLemieux73
Copy link
Contributor Author

Yes you need the code I have in

https://github.com/JFLemieux73/CICE/tree/OneGridChannels

With that code you should get transport even for the noisy boxislands test case.

@JFLemieux73
Copy link
Contributor Author

That's why I was asking if I should first do a PR with this branch.

@apcraig
Copy link
Contributor

apcraig commented Sep 18, 2023

I can do the code modifications as part of setting up the single channel tests. Will those modifications change answers to "standard" test cases? Is there a reason why these modifications aren't or haven't been added to the code before now?

@apcraig
Copy link
Contributor

apcraig commented Oct 17, 2023

See #875

@apcraig apcraig closed this as completed Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants