Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order attributes [FEATURE] #165

Open
cgsmith opened this issue Mar 6, 2023 · 6 comments · May be fixed by #170
Open

Order attributes [FEATURE] #165

cgsmith opened this issue Mar 6, 2023 · 6 comments · May be fixed by #170
Assignees
Labels
enhancement New feature or request

Comments

@cgsmith
Copy link
Contributor

cgsmith commented Mar 6, 2023

Is your feature request related to a problem? Please describe.
We currently have Order Notes and Notes. One is tied to the order and another to the customer. More often we are using these fields to make logic choices on but it is not ideal.
image

Describe the solution you'd like
I would like to be able to add order attributes to the order table. This column would be a JSON column which would allow the user to enter in custom attributes on orders. We can then use this data to filter orders.

Describe alternatives you've considered
I think it would be fine to have the JSON column just on the order table. Not sure if we need it to have a separate table.

@cgsmith cgsmith added the enhancement New feature or request label Mar 6, 2023
@cgsmith
Copy link
Contributor Author

cgsmith commented Mar 6, 2023

Attributes for the above example would look like this:

{
"RESHIP-STANDARD",
"TURLOCK",
"EXPRESS",
"Med-Cooler",
"1DAY"
}

@bohdan-vorona
Copy link
Contributor

@cgsmith

  1. But we also leave the fields Order notes and Notes (Ship To) without any changes?
  2. Are attributes unique for each order? I mean, as a user, every time I create/edit an order, I enter unique attributes?

Example:

  • I create Order A. I input attributes: Attr A, Attr B, Attr C.
  • I edit Order B. I input Attr C, Attr D.

In this case, when I edit Order B, I "don't know" about existing Attr C for Order A? But, in the meanwhile, using the filters, Order A and Order B will be shown together?

  1. Shall I add a new column to the listing with the attributes?

@cgsmith
Copy link
Contributor Author

cgsmith commented Mar 7, 2023

Great questions.

Yes leave notes and order notes alone for now. Attributes are unique even though they will be common amongst orders. For example, changing RESHIP to RESHIP1 will not change the attribute on any other order.

@bohdan-vorona
Copy link
Contributor

@cgsmith Ok, thanks.

@cgsmith
Copy link
Contributor Author

cgsmith commented Mar 7, 2023

A new column on the index would be useful. I'm imagining using Bootstrap Labels for the tags to display and the input box. Something similar to this for the input box: https://stackoverflow.com/a/14083331

@bohdan-vorona
Copy link
Contributor

bohdan-vorona commented Mar 7, 2023

@cgsmith Ok, I also was thinking about Labels )

@bohdan-vorona bohdan-vorona linked a pull request Mar 15, 2023 that will close this issue
@bohdan-vorona bohdan-vorona linked a pull request Mar 15, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants