Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up e2e test dockerfile #426

Open
msm-cert opened this issue Oct 17, 2024 · 0 comments
Open

Clean up e2e test dockerfile #426

msm-cert opened this issue Oct 17, 2024 · 0 comments
Labels
type:refactor Refactoring zone:backend Backend oriented tasks
Milestone

Comments

@msm-cert
Copy link
Member

Right now this setup is needlessly complicated:

      - name: run web with docker compose
        run: docker compose up --build -d web --wait
      - name: init the database
        run: docker compose exec -it -w /usr/src/app/src/ web alembic upgrade head
      - name: run the rest of the code
        run: docker compose up -d
      - name: run e2e tests
        run: docker run --net mquery_default -v $(readlink -f ./samples):/mnt/samples mquery_tests

specifically, this line is probably unnecessary, and we can start everything at once:

 -name: init the database
     run: docker compose exec -it -w /usr/src/app/src/ web alembic upgrade head

But before removing it we should make sure there are no race conditions and e2e tests still work.

It's possible that just this is enough for setup:

 docker compose up --build -d --wait

(and then run mquery_tests)

@msm-cert msm-cert added type:refactor Refactoring zone:backend Backend oriented tasks labels Oct 17, 2024
@msm-cert msm-cert added this to the v1.5.0 milestone Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:refactor Refactoring zone:backend Backend oriented tasks
Projects
None yet
Development

No branches or pull requests

1 participant