Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Copy button for for all hashes, and for each single hash #34

Closed
Tracked by #233
ITAYC0HEN opened this issue Apr 3, 2020 · 4 comments · Fixed by #156 or #239
Closed
Tracked by #233

Add a Copy button for for all hashes, and for each single hash #34

ITAYC0HEN opened this issue Apr 3, 2020 · 4 comments · Fixed by #156 or #239
Labels
priority:low Priority: low
Milestone

Comments

@ITAYC0HEN
Copy link
Collaborator

ITAYC0HEN commented Apr 3, 2020

Description
Currently, it is not easy to retrieve the hash of the sample. If you're lucky, the filename is the hash, and then you'll need to copy each filename.
I suggest to add buttons to:

  • Copy single hash (might be implemented by clicking on the cell)
  • Copy all hashes as
    • Sha256
    • Sha1
    • MD5

image

image

Related to #33

@msm-code msm-code added this to the v1.1.0 milestone Apr 8, 2020
@msm-code msm-code added priority:high Priority: high and removed priority:medium labels May 3, 2020
@KWMORALE KWMORALE self-assigned this May 7, 2020
@msm-code msm-code linked a pull request May 14, 2020 that will close this issue
2 tasks
@ITAYC0HEN
Copy link
Collaborator Author

Does not solve this completely because Copy All Hashes wasn't implemented

@msm-code
Copy link
Contributor

Right, I've misunderstood this issue and thought that copy all hashes means "download a file with all hashes" (done with #163).

Actually I didn't even know that there's an option to copy all hashes. Do you find it useful often? To implement it we'll have to compute all the hashes after the query for every file, or think about caching them somewhere.

I'd like to avoid having too much metadata in mquery (it's not useful for us, because we use mwdb for that), but I can reconsider and/or create a new issue for that if that's important.

@ITAYC0HEN
Copy link
Collaborator Author

aren't the hashes there already when displaying the sha256 on the table? Or they are calculated for 20 samples at a time?

@msm-code
Copy link
Contributor

Nevermind, looks like I've missed the point twice in a row. I've actually checked VT how it works now,

Yeah, all sha256 hashes are in the db. I don't think we can reuse the endpoint used to download the list of the hashes, but the code will be almost the same. I'll reopen it.

@msm-code msm-code reopened this May 15, 2020
@msm-code msm-code modified the milestones: v1.2.0, v1.3.0 May 15, 2020
@msm-code msm-code added level:easy priority:low Priority: low and removed level:medium priority:high Priority: high labels May 15, 2020
This was referenced Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:low Priority: low
Projects
None yet
3 participants