Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit handling of default priors #131

Closed
seabbs opened this issue Mar 8, 2024 · 2 comments · Fixed by #162
Closed

Revisit handling of default priors #131

seabbs opened this issue Mar 8, 2024 · 2 comments · Fixed by #162
Labels
enhancement New feature or request EpiAware

Comments

@seabbs
Copy link
Collaborator

seabbs commented Mar 8, 2024

Default priors are currently handled by small helper functions that have custom names. This seems surprisingly clunky given the rest of the code base.

Whilst I agree default priors in structs could be dangerous in the hands of some users I also think providing opinionated priors can be very helpful and also guide practice.

Personally I would vote for default priors in the structs but open to other suggestions?

@SamuelBrand1
Copy link
Collaborator

My view is that if we can close #133 in such a way that all priors have defaults for their constructor; then this is closed too.

@seabbs
Copy link
Collaborator Author

seabbs commented Mar 21, 2024

I think this is now resolved? (checked and yes closed by #162)

@seabbs seabbs closed this as completed Mar 21, 2024
@seabbs seabbs reopened this Mar 21, 2024
@seabbs seabbs linked a pull request Mar 21, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request EpiAware
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants