Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace png() width and height with magnification #208

Open
danlipsa opened this issue Jun 30, 2017 · 5 comments
Open

replace png() width and height with magnification #208

danlipsa opened this issue Jun 30, 2017 · 5 comments
Assignees
Milestone

Comments

@danlipsa
Copy link
Contributor

vtkWindowToImageFilter which is used in png() to get an image from the window supports a parameter int magnification which allows the user to save a larger image than the window size.

Note this does not change the width/height ratio, so probably we won't need to replot anything in changeEvent. This will get rid of a large chunk of tricky code and probably speedup computation when resizing is involved.

It will involve an incompatible change and resizing will be more limited it maybe worth investigating.

@doutriaux1 @aashish24 @sankhesh @williams13 What do you think?

@doutriaux1
Copy link
Contributor

@danlipsa yes and no, if the user is looking a dastaon the screen at a certain ratio but the output ratio is different we need to re-render.

@danlipsa
Copy link
Contributor Author

danlipsa commented Jul 5, 2017

@doutriaux1 I agree with that. The question is if the user really needs a resize that involves changing the ratio or what he needs is to save a larger image (higher resolution).
If the user only needs a larger image (which I think it is the case) we can get rid of the code from changeEvent (and the headache that comes with it).

@danlipsa
Copy link
Contributor Author

danlipsa commented Jul 5, 2017

@doutriaux1 If the user wants a specific ratio, he can resize the window to that ratio than save the (potential larger) png.

@danlipsa
Copy link
Contributor Author

danlipsa commented Jul 5, 2017

So I guess the code in changeEvent still needs to be there for this kind of resizing.

@doutriaux1
Copy link
Contributor

@danlipsa we should still implement the magnify for png in case the ratio doesn't change or is within some margin of error.

@doutriaux1 doutriaux1 added this to the 3.0 milestone Sep 5, 2017
@doutriaux1 doutriaux1 modified the milestones: 3.0, Next Release Mar 29, 2018
@doutriaux1 doutriaux1 modified the milestones: 8.1, 8.2 Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants