Regrid2#15 #120
Merged
Regrid2#15 #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fix #15 |
|
@dnadeau4 opened or closed? It's not merged! |
|
I think my comment closed it by mistake. |
|
Please merge @doutriaux1 |
doutriaux1
suggested changes
Apr 26, 2017
| @@ -6,6 +6,7 @@ | |||
|
|
|||
| import cdms2, numpy, os, sys | |||
| import basetest | |||
| import pdb | |||
| @@ -1,6 +1,6 @@ | |||
|
|
|||
| import cdms2, numpy.ma, regrid2 as regrid, os, sys | |||
| from regrid2 import Regridder | |||
| from regrid2 import Horizontal | |||
There was a problem hiding this comment.
why did we change this? Shouldn't we have 2 tests?
There was a problem hiding this comment.
Because of this warning.
https://github.com/UV-CDAT/cdms/blob/master/regrid2/Lib/horizontal.py#L291-L294
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #5 and #15 are in this pull request.