-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Establish a release workflow for docker images #693
Comments
@knikolla is this the sort of workflow you envisioned? https://github.com/cci-moc/image-workflow-example |
I'm assuming you meant 'sort of workflow', yes. Nice touch on also tagging |
Great, then let's discuss some details. :) That workflow is triggered by pushing a tag, which is simple, but has some disadvantages -- primarily, it requires direct commit access to the repository, and bypasses any existing review process. In some of my non-image repositories, I do things effectively "in reverse": a commit to a specific file triggers a release workflow, which then extracts the release version from the repository and generates a release. I like this model, but I haven't tried adapting it to a container image (where we often want per-commit images as well as release images). |
As discussed in backlog grooming, for now, I think requiring push access to creating releases sounds like a good compromise in keeping things simple. |
I think this can be closed. |
I think this can be closed. |
On the team check-in today, @knikolla expressed a preference for using commit hashes from the main branch as image tags rather than using branch names (to ensure that a deployment continues to use the same image unless it is explicitly changed). This becomes slightly problematic when the same repository houses both the Docker image sources and the openshift deployment manifests.
Kristi suggested an alternative approach using semantic versioning and named tags. There are a number of ways to automate this process; we would like to collect some examples of existing workflows so we can pick one that works well for our projects.
We can collect pointers to good example repositories (and generally discuss the topic of automated release workflows) here in this issue.
The text was updated successfully, but these errors were encountered: