Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Establish a release workflow for docker images #693

Closed
larsks opened this issue Sep 15, 2022 · 7 comments
Closed

Establish a release workflow for docker images #693

larsks opened this issue Sep 15, 2022 · 7 comments
Assignees

Comments

@larsks
Copy link
Member

larsks commented Sep 15, 2022

On the team check-in today, @knikolla expressed a preference for using commit hashes from the main branch as image tags rather than using branch names (to ensure that a deployment continues to use the same image unless it is explicitly changed). This becomes slightly problematic when the same repository houses both the Docker image sources and the openshift deployment manifests.

Kristi suggested an alternative approach using semantic versioning and named tags. There are a number of ways to automate this process; we would like to collect some examples of existing workflows so we can pick one that works well for our projects.

We can collect pointers to good example repositories (and generally discuss the topic of automated release workflows) here in this issue.

@knikolla
Copy link

CCI-MOC/ops-docs#22

@larsks
Copy link
Member Author

larsks commented Sep 21, 2022

@knikolla is this the sort of workflow you envisioned? https://github.com/cci-moc/image-workflow-example

@knikolla
Copy link

I'm assuming you meant 'sort of workflow', yes. Nice touch on also tagging vX and vX.Y on a new vX.Y.Z release!

@larsks
Copy link
Member Author

larsks commented Sep 22, 2022

Great, then let's discuss some details. :)

That workflow is triggered by pushing a tag, which is simple, but has some disadvantages -- primarily, it requires direct commit access to the repository, and bypasses any existing review process.

In some of my non-image repositories, I do things effectively "in reverse": a commit to a specific file triggers a release workflow, which then extracts the release version from the repository and generates a release.

I like this model, but I haven't tried adapting it to a container image (where we often want per-commit images as well as release images).

@knikolla
Copy link

As discussed in backlog grooming, for now, I think requiring push access to creating releases sounds like a good compromise in keeping things simple.

@larsks
Copy link
Member Author

larsks commented Feb 15, 2023

I think this can be closed.

@larsks larsks closed this as completed Feb 15, 2023
@larsks
Copy link
Member Author

larsks commented Feb 15, 2023

I think this can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants