From 78844d7bd55990789ed07c81e49043e688cbe656 Mon Sep 17 00:00:00 2001
From: C4illin <emrik.ostling@gmail.com>
Date: Sat, 5 Oct 2024 01:20:23 +0200
Subject: [PATCH] fix: disable convert button when input is empty

issue #151
---
 src/index.tsx        | 85 +++++++++++++++++++++++++++-----------------
 src/public/script.js |  7 ++++
 2 files changed, 59 insertions(+), 33 deletions(-)

diff --git a/src/index.tsx b/src/index.tsx
index da51b5f..6191690 100644
--- a/src/index.tsx
+++ b/src/index.tsx
@@ -575,11 +575,13 @@ const app = new Elysia({
                   class="w-full rounded bg-neutral-800 p-4"
                 />
                 <div class="select_container relative">
-                  <article class={`
-                    convert_to_popup absolute z-[2] m-0 hidden h-[30vh] max-h-[50vh] w-full flex-col
-                    overflow-y-auto overflow-x-hidden rounded bg-neutral-800
-                    sm:h-[30vh]
-                  `}>
+                  <article
+                    class={`
+                      convert_to_popup absolute z-[2] m-0 hidden h-[30vh] max-h-[50vh] w-full
+                      flex-col overflow-y-auto overflow-x-hidden rounded bg-neutral-800
+                      sm:h-[30vh]
+                    `}
+                  >
                     {Object.entries(getAllTargets()).map(
                       ([converter, targets]) => (
                         <article
@@ -639,7 +641,15 @@ const app = new Elysia({
                   </select>
                 </div>
               </article>
-              <input class="btn-primary w-full" type="submit" value="Convert" />
+              <input
+                class={`
+                  btn-primary w-full
+                  disabled:cursor-not-allowed disabled:opacity-50
+                `}
+                type="submit"
+                value="Convert"
+                disabled
+              />
             </form>
           </main>
           <script src="script.js" defer />
@@ -652,11 +662,13 @@ const app = new Elysia({
     ({ body }) => {
       return (
         <>
-          <article class={`
-            convert_to_popup absolute z-[2] m-0 hidden h-[50vh] max-h-[50vh] w-full flex-col
-            overflow-y-auto overflow-x-hidden rounded bg-neutral-800
-            sm:h-[30vh]
-          `}>
+          <article
+            class={`
+              convert_to_popup absolute z-[2] m-0 hidden h-[50vh] max-h-[50vh] w-full flex-col
+              overflow-y-auto overflow-x-hidden rounded bg-neutral-800
+              sm:h-[30vh]
+            `}
+          >
             {Object.entries(getPossibleTargets(body.fileType)).map(
               ([converter, targets]) => (
                 <article
@@ -743,7 +755,6 @@ const app = new Elysia({
             await Bun.write(`${userUploadsDir}${file.name}`, file);
           }
         } else {
-           
           await Bun.write(`${userUploadsDir}${body.file["name"]}`, body.file);
         }
       }
@@ -923,11 +934,13 @@ const app = new Elysia({
           <main class="w-full px-4">
             <article class="article">
               <h1 class="mb-4 text-xl">Results</h1>
-              <table class={`
-                w-full table-auto rounded bg-neutral-900 text-left
-                [&_td]:p-4
-                [&_tr]:rounded [&_tr]:border-b [&_tr]:border-neutral-800
-              `}>
+              <table
+                class={`
+                  w-full table-auto rounded bg-neutral-900 text-left
+                  [&_td]:p-4
+                  [&_tr]:rounded [&_tr]:border-b [&_tr]:border-neutral-800
+                `}
+              >
                 <thead>
                   <tr>
                     <th class="px-4 py-2">Time</th>
@@ -1036,11 +1049,13 @@ const app = new Elysia({
                     [&[value]::-webkit-progress-value]:transition-[inline-size]
                   `}
                 />
-                <table class={`
-                  w-full table-auto rounded bg-neutral-900 text-left
-                  [&_td]:p-4
-                  [&_tr]:rounded [&_tr]:border-b [&_tr]:border-neutral-800
-                `}>
+                <table
+                  class={`
+                    w-full table-auto rounded bg-neutral-900 text-left
+                    [&_td]:p-4
+                    [&_tr]:rounded [&_tr]:border-b [&_tr]:border-neutral-800
+                  `}
+                >
                   <thead>
                     <tr>
                       <th class="px-4 py-2">Converted File Name</th>
@@ -1156,11 +1171,13 @@ const app = new Elysia({
               [&[value]::-webkit-progress-value]:transition-[inline-size]
             `}
           />
-          <table class={`
-            w-full table-auto rounded bg-neutral-900 text-left
-            [&_td]:p-4
-            [&_tr]:rounded [&_tr]:border-b [&_tr]:border-neutral-800
-          `}>
+          <table
+            class={`
+              w-full table-auto rounded bg-neutral-900 text-left
+              [&_td]:p-4
+              [&_tr]:rounded [&_tr]:border-b [&_tr]:border-neutral-800
+            `}
+          >
             <thead>
               <tr>
                 <th class="px-4 py-2">Converted File Name</th>
@@ -1250,12 +1267,14 @@ const app = new Elysia({
           <main class="w-full px-4">
             <article class="article">
               <h1 class="mb-4 text-xl">Converters</h1>
-              <table class={`
-                w-full table-auto rounded bg-neutral-900 text-left
-                [&_td]:p-4
-                [&_tr]:rounded [&_tr]:border-b [&_tr]:border-neutral-800
-                [&_ul]:list-inside [&_ul]:list-disc
-              `}>
+              <table
+                class={`
+                  w-full table-auto rounded bg-neutral-900 text-left
+                  [&_td]:p-4
+                  [&_tr]:rounded [&_tr]:border-b [&_tr]:border-neutral-800
+                  [&_ul]:list-inside [&_ul]:list-disc
+                `}
+              >
                 <thead>
                   <tr>
                     <th class="mx-4 my-2">Converter</th>
diff --git a/src/public/script.js b/src/public/script.js
index b513b0c..2f65439 100644
--- a/src/public/script.js
+++ b/src/public/script.js
@@ -22,6 +22,7 @@ const updateSearchBar = () => {
   const convertToGroupElements = document.querySelectorAll(".convert_to_group");
   const convertToGroups = {};
   const convertToElement = document.querySelector("select[name='convert_to']");
+  const convertButton = document.querySelector("input[type='submit']");
 
   const showMatching = (search) => {
     for (const [targets, groupElement] of Object.values(convertToGroups)) {
@@ -57,6 +58,7 @@ const updateSearchBar = () => {
       target.onmousedown = () => {
         convertToElement.value = target.dataset.value;
         convertToInput.value = `${target.dataset.target} using ${target.dataset.converter}`;
+        convertButton.disabled = false;
         showMatching("");
       };
     }
@@ -68,6 +70,11 @@ const updateSearchBar = () => {
     showMatching(e.target.value.toLowerCase());
   });
 
+  convertToInput.addEventListener("search", () => {
+    // when the user clears the search bar using the 'x' button
+    convertButton.disabled = true;
+  });
+
   convertToInput.addEventListener("blur", (e) => {
     // Keep the popup open even when clicking on a target button
     // for a split second to allow the click to go through