Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the order of the origin to be in first place to match ICON index … #439

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

halungge
Copy link
Contributor

@halungge halungge commented Apr 11, 2024

Adjust column order of offset including origin. ICON expects the origins to be in the first place.

@halungge halungge requested a review from abishekg7 April 11, 2024 14:08
Copy link

Mandatory Tests

Please make sure you run these tests via comment before you merge!

  • cscs-ci run default
  • launch jenkins spack

Optional Tests

To run benchmarks you can use:

  • cscs-ci run benchmark

To run tests and benchmarks with the DaCe backend you can use:

  • cscs-ci run dace

In case your change might affect downstream icon-exclaim, please consider running

  • launch jenkins icon

For more detailed information please look at CI in the EXCLAIM universe.

@halungge
Copy link
Contributor Author

cscs-ci run default

@halungge
Copy link
Contributor Author

launch jenkins spack

Copy link
Contributor

@abishekg7 abishekg7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@halungge halungge merged commit 7d61b04 into main Apr 11, 2024
5 checks passed
iomaganaris referenced this pull request in iomaganaris/icon4py Jun 18, 2024
…… (#439)

* fix the order of the origin to be in first place to match ICON index ordering in coefficients

* pre-commit
@halungge halungge deleted the fix_ordering_of_origin_offsets branch December 12, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants