Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type errors liskov validation #298

Merged
merged 2 commits into from
Oct 19, 2023
Merged

Fix type errors liskov validation #298

merged 2 commits into from
Oct 19, 2023

Conversation

samkellerhals
Copy link
Contributor

No description provided.

@samkellerhals
Copy link
Contributor Author

cscs-ci run

@samkellerhals
Copy link
Contributor Author

launch jenkins spack

@github-actions
Copy link

Mandatory Tests

Please make sure you run these tests via comment before you merge!

  • cscs-ci run
  • launch jenkins spack

Optional Tests

In case your change might affect downstream icon-exclaim, please consider running

  • launch jenkins icon

For more detailed information please look at CI in the EXCLAIM universe.

@samkellerhals
Copy link
Contributor Author

cscs-ci run

@samkellerhals
Copy link
Contributor Author

launch jenkins spack

halungge
halungge approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@halungge halungge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still wondering about the errors that were in py2f... but nothing was changed there so..

@samkellerhals
Copy link
Contributor Author

Still wondering about the errors that were in py2f... but nothing was changed there so..

I think those were actually just warnings.

@samkellerhals samkellerhals merged commit 3b99e48 into main Oct 19, 2023
2 checks passed
@samkellerhals samkellerhals deleted the fix-type-error branch October 19, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@halungge halungge halungge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samkellerhals @halungge