-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optional dependencies #283
Conversation
launch jenkins spack |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good. I also added fixes for a docstring typo and a missing type hint, but those are very minor non-blocking issues.
model/common/src/icon4py/model/common/decomposition/definitions.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Enrique G. Paredes <[email protected]>
…s.py Co-authored-by: Enrique G. Paredes <[email protected]>
…into make-optional-dependencies
cscs-ci run |
1 similar comment
cscs-ci run |
launch jenkins spack |
This reverts commit 9857270.
Mandatory Tests Please make sure you run these tests via comment before you merge!
Optional Tests In case your change might affect downstream icon-exclaim, please consider running
For more detailed information please look at CI in the EXCLAIM universe. |
launch jenkins spack |
cscs-ci run |
makes ghex, mpi4py, netcdf an optional dependencies