Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optional dependencies #283

Merged
merged 31 commits into from
Oct 2, 2023
Merged

optional dependencies #283

merged 31 commits into from
Oct 2, 2023

Conversation

halungge
Copy link
Contributor

makes ghex, mpi4py, netcdf an optional dependencies

@halungge halungge requested a review from egparedes September 30, 2023 14:04
@halungge
Copy link
Contributor Author

launch jenkins spack

Copy link
Contributor

@egparedes egparedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good. I also added fixes for a docstring typo and a missing type hint, but those are very minor non-blocking issues.

model/driver/README.md Outdated Show resolved Hide resolved
Co-authored-by: Enrique G. Paredes <[email protected]>
@halungge
Copy link
Contributor Author

halungge commented Oct 2, 2023

cscs-ci run

1 similar comment
@halungge
Copy link
Contributor Author

halungge commented Oct 2, 2023

cscs-ci run

@halungge
Copy link
Contributor Author

halungge commented Oct 2, 2023

launch jenkins spack

@github-actions
Copy link

github-actions bot commented Oct 2, 2023

Mandatory Tests

Please make sure you run these tests via comment before you merge!

  • launch jenkins spack

Optional Tests

In case your change might affect downstream icon-exclaim, please consider running

  • launch jenkins icon

For more detailed information please look at CI in the EXCLAIM universe.

@halungge
Copy link
Contributor Author

halungge commented Oct 2, 2023

launch jenkins spack

@halungge
Copy link
Contributor Author

halungge commented Oct 2, 2023

cscs-ci run

@halungge halungge merged commit 18ddbbc into main Oct 2, 2023
3 checks passed
@egparedes egparedes deleted the make-optional-dependencies branch November 7, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants