New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix imports for Webpack #4

Closed

atav32 opened this issue Sep 20, 2018 · 1 comment · Fixed by #5

Assignees

Labels

atav32 commented Sep 20, 2018

Like this: janpaepke#684

So that people don't have to keep doing this janpaepke#324 (comment) and this janpaepke#685 (comment)

atav32 added the enhancement label

atav32 self-assigned this

This was referenced Sep 20, 2018

Fix webpack import janpaepke/ScrollMagic#834

Closed

hopefully fix webpack imports #5

Merged

atav32 closed this as completed in #5

Author

atav32 commented Sep 21, 2018

A couple things to remember for the future

everything's easier when the module name and all imports reference a lowercase name
a) changed "ScrollMagic" to "scrollmagic" (except the class name)
ES6 imports work better when ScrollMagic references the UMD versions of GSAP TweenMax
still need a Webpack/Babel alias to help animation.gspa.js find the module scrollmagic and point it to scrollmagic.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment