Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore statfs for FreeBSD & OpenBSD #87

Merged
merged 2 commits into from
Oct 18, 2023
Merged

Restore statfs for FreeBSD & OpenBSD #87

merged 2 commits into from
Oct 18, 2023

Conversation

0323pin
Copy link
Contributor

@0323pin 0323pin commented Oct 17, 2023

Fixes #86

@Byron Probably possible to simplify but, let's wait for a confirmation in the referenced issue.

@Byron
Copy link
Owner

Byron commented Oct 18, 2023

Thanks for the fix.

CI really needs an upgrade as these targets aren't tested, and I can't validate the code myself either. If issues keep arising, and in absence of CI, it would probably be better to remove support for these platforms than to carry on with them.

@Byron Byron merged commit fed239b into Byron:master Oct 18, 2023
3 checks passed
@0323pin
Copy link
Contributor Author

0323pin commented Oct 18, 2023

Thanks!

it would probably be better to remove support for these platforms than to carry on with them

Please don't. Just ask, I can do test builds when required 🙏

@Byron
Copy link
Owner

Byron commented Oct 18, 2023

Why can't CI be testing these platforms? Aren't other projects on GitHub doing this already, so a CI configuration example could be fetched from there?

Unless you are running all tests on FreeBSD and NetBSD as each commit in each PR happens, I don't think these platforms will be protected from regression. They also cost a disproportionate amount of my time right now.

Maybe they should be considered a different tier and breakage is simply allowed - what CI doesn't see doesn't exist.

@0323pin
Copy link
Contributor Author

0323pin commented Oct 18, 2023

@Byron I understand your annoyance and I'm aware I was the one causing this issue.

My offer to run test builds is only due to the fact that I don't know how to set-up a CI.

Why can't CI be testing these platforms? Aren't other projects on GitHub doing this already, so a CI configuration example could be fetched from there?

Yes, Rust libc does this. Cirrus CI has support for all the 3 platforms discussed here. And, since this is a library not requiring any graphics, it could be straightforward to set-up something like trippy has.
It's just that, I have no clue how to configure and set-up a CI 😢

@Byron
Copy link
Owner

Byron commented Oct 18, 2023

Great, trippy can lead the way as it has netbsd at least, and a cross-setup to make it all work. To get started, you could enable CI in your fork, copy the CI configuration file from trippy and then adjust it so that cross runs tests instead of just building a binary.

I really think it will be time well spend to try to adapt the trippy CI to work with this project, and I am absolutely looking forward to a PR for this. You can do it :)!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fails to build on FreeBSD
2 participants