Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add filesystem time deletion to TrashItem #78

Open
ramsteak opened this issue Jul 7, 2023 · 3 comments
Open

add filesystem time deletion to TrashItem #78

ramsteak opened this issue Jul 7, 2023 · 3 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@ramsteak
Copy link

ramsteak commented Jul 7, 2023

I'd like if the filesystem time of deletion was accessible for TrashItem elements, as in windows the std::fs times are not in i64 UNIX timestamp but in u64 windows filetime, and calculating differences requires converting back and forth between the two formats

@Byron Byron added enhancement New feature or request help wanted Extra attention is needed labels Jul 8, 2023
@Byron
Copy link
Owner

Byron commented Jul 8, 2023

Thanks for reporting. Unifying the representation of time across platforms seems like a valuable addition, thanks for sharing.

@ramsteak
Copy link
Author

ramsteak commented Jul 8, 2023

I made a pull request #79 to add this attribute

@ramsteak
Copy link
Author

ramsteak commented Aug 2, 2023

Deleted PR, this change would actually make it harder to work cross-platform and would require checks for windows and unix separately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants