Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check_code_block_token_count function #65

Merged
merged 2 commits into from
Jan 25, 2024

Conversation

dalance
Copy link
Contributor

@dalance dalance commented Jan 24, 2024

This PR adds check_code_block_token_count function which can be used to decide an appropriate valud of code_block_token_count.

See #20

- rename function, some doc-string fixes
- Use `IntoIterator` instead of `Iterator`
Copy link
Owner

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, great work!

I made minor adjustments, and when CI is green this PR will be merged, and a new release will be created.

@@ -76,6 +76,8 @@ pub struct Options<'a> {
pub newlines_after_list: usize,
pub newlines_after_blockquote: usize,
pub newlines_after_rest: usize,
/// Token count for fenced code block. An appropriate value of this field can be decided by
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I see why it was called token count, not backtick count - ~ can be used instead of backticks.

@Byron Byron merged commit 10b855f into Byron:main Jan 25, 2024
1 check passed
@Byron
Copy link
Owner

Byron commented Jan 25, 2024

And here is the release: https://github.com/Byron/pulldown-cmark-to-cmark/releases/tag/v11.1.0 .

Fun fact: When I write 'when CI is green' I expect long CI runtimes. Here, however, it only takes 11 seconds so writing this wasn't actually required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants