Make the number of backticks in codeblocks configurable #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a breaking change because it adds a member to the publically constructable `Options` struct.
|
Thanks a lot for your contribution! I didn’t even know it’s flexible regarding the amount of backticks, but if it works for you, I am happy to merge. Will release a major version in a bit. |
|
The spec defines it as at least three backticks or tildes. Three backticks is the only thing I think I've seen in practise, but I left the default at four. |
|
I recall now that the reason for defaulting to four backticks is to support nesting reliably, even with the limited information the v5.0.0 was just released. |
This was referenced Aug 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change because it adds a member to the publicly
constructable
Optionsstruct.Fixes #17