allows HTTPNetworkTransport to take URLSession instance #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…caller to handle exceptional cases by way of URLSessionDelegate
|
might be worth updating this fork at some point. it looks a decent bit behind. though i guess you may not be able to upgrade to the versions that use swift 5 yet? |
I think it was last updated in May. I'll put it in our todos. We switched to Swift 5 so it shouldn't be a blocker. Any significant new features you know of? |
|
it looks like there were some interesting refactors in v0.12: https://github.com/apollographql/apollo-ios/blob/master/CHANGELOG.md#v0120 though at least on the cloud side, for upgrades, it's more like "why not" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings apollographql#265 into our fork.
We need this capability so we can handle the session's
URLAuthenticationChallenge.