Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax type checking to allow heterogenous arrays #305

Closed
ear7h opened this issue Jun 25, 2021 · 2 comments · Fixed by #306
Closed

Relax type checking to allow heterogenous arrays #305

ear7h opened this issue Jun 25, 2021 · 2 comments · Fixed by #306

Comments

@ear7h
Copy link

ear7h commented Jun 25, 2021

Heterogeneous arrays were added in version 1.0.0-rc.1.

I'm willing to submit a pr/tests but wanted to know what the maintainers' thoughts are since this is could be considered a breaking change

@arp242
Copy link
Collaborator

arp242 commented Jun 25, 2021

Yeah, I thought this was already fixed/added before I took over maintainership, but it seems that I misread something and that it's not.

Coincidentally, I was actually working on this just now. The decoding part is pretty easy and just consists of deleting some code; the encoding part is a bit more involved; I have something that almost-but-not-quite-yet works 😅

Either way, should be added soon™.

@ear7h
Copy link
Author

ear7h commented Jun 25, 2021

Sounds good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants