Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style changed between releases #266

Closed
sophiajt opened this issue Dec 3, 2016 · 5 comments
Closed

Style changed between releases #266

sophiajt opened this issue Dec 3, 2016 · 5 comments
Labels
question An issue that is lacking clarity on one or more points.

Comments

@sophiajt
Copy link

sophiajt commented Dec 3, 2016

Originally, ripgrep had nice bold highlights for matches, which made it easy to read on white terminals:

screen shot 2016-12-03 at 8 14 16 am

The more recent version uses slightly different colors and no bold. This is a bit harder to read on the white background:

screen shot 2016-12-03 at 8 13 14 am

Would love a way to switch back to the earlier colors

@BurntSushi
Copy link
Owner

BurntSushi commented Dec 3, 2016

This certainly wasn't intended. The current default colors should all be bold.

I wonder what happens if you try a bit of experimenting. In ripgrep 0.3, you can now customize colors/styles to a limited extent. e.g., What happens if you try this:

rg --colors line:style:nobold --colors match:style:nobold --colors path:style:nobold lookup_method

Finally, what terminal emulator are you using?

@BurntSushi BurntSushi added the question An issue that is lacking clarity on one or more points. label Dec 3, 2016
@BurntSushi
Copy link
Owner

BurntSushi commented Dec 3, 2016

I wonder if this is because I've made "bold + color" imply "high intensity color," and as a result, never actually emit the bold ANSI escape sequence.

@sophiajt
Copy link
Author

sophiajt commented Dec 4, 2016

With your line I get:

screen shot 2016-12-04 at 10 38 33 am

I'm just using the default macOS terminal with Basic theme.

@BurntSushi
Copy link
Owner

Okay. I will try to hook up my mac to a monitor and test this.

@ivan
Copy link

ivan commented Dec 12, 2016

With roxterm (which uses libvte), I also get different shades of red with match:style:nobold and match:style:bold, but neither is bold now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question An issue that is lacking clarity on one or more points.
Projects
None yet
Development

No branches or pull requests

3 participants