Whitelisting via .gitignore does not handle dot prefix ("!./fname")

[blueyed]

Given a .gitignore file:

*
!./PKGBUILD

rg will skip the PKGBUILD file:

DEBUG|ignore::walk|ignore/src/walk.rs:1639: ignoring ./PKGBUILD: Ignore(IgnoreMatch(Gitignore(Glob { from: Some("./.gitignore"), original: "", actual: "**/", is_whitelist: false, is_only_dir: false })))

This appears to be due to the leading dot there.
Git handles this as expected.

Removing the dot (using !/PKGBUILD) whitelists it then:

DEBUG|ignore::walk|ignore/src/walk.rs:1642: whitelisting ./PKGBUILD: Whitelist(IgnoreMatch(Gitignore(Glob { from: Some("./.gitignore"), original: "!/PKGBUILD", actual: "PKGBUILD", is_whitelist: true, is_only_dir: false })))

What version of ripgrep are you using?

ripgrep 11.0.2

[goto-engineering]

I just tried this, and my git (2.25.1) seems to show the same behavior:

*
!./test

does not show the test file under git status, whereas

*
!test

does show it.

ripgrep has the exact same behavior.

Even when my .gitignore simply contains:

./test

the test file is NOT being git-ignored. Are we sure that the ./ syntax is supported by gitignore?

[BurntSushi]

@blueyed Can you clarify what you meant by "git handles this as expected" in your initial bug report here?

[czarnota]

IMHO this is the expected behavior

https://git-scm.com/docs/gitignore

An optional prefix "!" which negates the pattern; any matching file excluded by a previous pattern will become included again. It is not possible to re-include a file if a parent directory of that file is excluded. Git doesn’t list excluded directories for performance reasons, so any patterns on contained files have no effect, no matter where they are defined.

the dot . is a synonym for the parent directory of .gitignore, so in the case of

!./PKGBUILD

"It is not possible to re-include a file if a parent directory (in this case .) of that file is excluded."

Furthermore:

If you specify this .gitignore

*
!foo/bar

$ tree -a
.
├── foo
│   └── bar
└── .gitignore

Then git status also gives you nothing

$ git status
On branch master

No commits yet

nothing to commit (create/copy files and use "git add" to track)

[BurntSushi]

Closing as not a bug. Happy to revisit with more compelling data.