From b3f9e0fbd339171de226f454d9929ae95163d10b Mon Sep 17 00:00:00 2001 From: Jonathan Leitschuh Date: Fri, 29 Jul 2022 13:23:47 +0000 Subject: [PATCH] vuln-fix: Partial Path Traversal Vulnerability This fixes a partial path traversal vulnerability. Replaces `dir.getCanonicalPath().startsWith(parent.getCanonicalPath())`, which is vulnerable to partial path traversal attacks, with the more secure `dir.getCanonicalFile().toPath().startsWith(parent.getCanonicalFile().toPath())`. To demonstrate this vulnerability, consider `"/usr/outnot".startsWith("/usr/out")`. The check is bypassed although `/outnot` is not under the `/out` directory. It's important to understand that the terminating slash may be removed when using various `String` representations of the `File` object. For example, on Linux, `println(new File("/var"))` will print `/var`, but `println(new File("/var", "/")` will print `/var/`; however, `println(new File("/var", "/").getCanonicalPath())` will print `/var`. Weakness: CWE-22: Improper Limitation of a Pathname to a Restricted Directory ('Path Traversal') Severity: Medium CVSSS: 6.1 Detection: CodeQL & OpenRewrite (https://public.moderne.io/recipes/org.openrewrite.java.security.PartialPathTraversalVulnerability) Reported-by: Jonathan Leitschuh Signed-off-by: Jonathan Leitschuh Bug-tracker: https://github.com/JLLeitschuh/security-research/issues/13 Co-authored-by: Moderne --- .../java/org/jenkinsci/plugins/redpen/RedpenJobProperty.java | 2 +- .../org/jenkinsci/plugins/redpen/service/RedpenJenkinsCore.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main/java/org/jenkinsci/plugins/redpen/RedpenJobProperty.java b/src/main/java/org/jenkinsci/plugins/redpen/RedpenJobProperty.java index 5669e8d..ec0d678 100644 --- a/src/main/java/org/jenkinsci/plugins/redpen/RedpenJobProperty.java +++ b/src/main/java/org/jenkinsci/plugins/redpen/RedpenJobProperty.java @@ -201,7 +201,7 @@ private FormValidation doCheckTestFrameWorkPath(String value) { } try { File file = new File(basePath, value); - if (file.getCanonicalPath().startsWith(basePath)) { + if (file.getCanonicalFile().toPath().startsWith(basePath)) { return FormValidation.ok(); } } catch (IOException e) { diff --git a/src/main/java/org/jenkinsci/plugins/redpen/service/RedpenJenkinsCore.java b/src/main/java/org/jenkinsci/plugins/redpen/service/RedpenJenkinsCore.java index 885d504..c39813e 100644 --- a/src/main/java/org/jenkinsci/plugins/redpen/service/RedpenJenkinsCore.java +++ b/src/main/java/org/jenkinsci/plugins/redpen/service/RedpenJenkinsCore.java @@ -98,7 +98,7 @@ private AttachmentModel addAttachments(ParameterModel parameter, String jwtToken for (String s : logDir) { String trimPath = s.trim(); File file = new File(workspaceBasePath, trimPath); - if (!StringUtils.isBlank(trimPath) && file.getCanonicalPath().startsWith(workspaceBasePath)) { + if (!StringUtils.isBlank(trimPath) && file.getCanonicalFile().toPath().startsWith(workspaceBasePath)) { String logPath = file.getAbsolutePath(); AttachmentModel reportFiles = attachLogFiles(buildTriggerTime, workspaceBasePath, logPath, issueKey, jwtToken, "", "Other Files", true); uploadedFileNames.addAll(reportFiles.getAttachments());