From 88ae3a2ef56454671d7df57aa9e9e06bdb458b6d Mon Sep 17 00:00:00 2001 From: Jonathan Leitschuh Date: Wed, 21 Sep 2022 15:24:23 +0000 Subject: [PATCH] vuln-fix: Partial Path Traversal Vulnerability This fixes a partial path traversal vulnerability. Replaces `dir.getCanonicalPath().startsWith(parent.getCanonicalPath())`, which is vulnerable to partial path traversal attacks, with the more secure `dir.getCanonicalFile().toPath().startsWith(parent.getCanonicalFile().toPath())`. To demonstrate this vulnerability, consider `"/usr/outnot".startsWith("/usr/out")`. The check is bypassed although `/outnot` is not under the `/out` directory. It's important to understand that the terminating slash may be removed when using various `String` representations of the `File` object. For example, on Linux, `println(new File("/var"))` will print `/var`, but `println(new File("/var", "/")` will print `/var/`; however, `println(new File("/var", "/").getCanonicalPath())` will print `/var`. Weakness: CWE-22: Improper Limitation of a Pathname to a Restricted Directory ('Path Traversal') Severity: Medium CVSSS: 6.1 Detection: CodeQL & OpenRewrite (https://public.moderne.io/recipes/org.openrewrite.java.security.PartialPathTraversalVulnerability) Reported-by: Jonathan Leitschuh Signed-off-by: Jonathan Leitschuh Bug-tracker: https://github.com/JLLeitschuh/security-research/issues/13 Co-authored-by: Moderne --- .../org/jenkinsci/plugins/artifactdiff/ArtifactDifference.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/org/jenkinsci/plugins/artifactdiff/ArtifactDifference.java b/src/main/java/org/jenkinsci/plugins/artifactdiff/ArtifactDifference.java index 28a315b..586ca7d 100644 --- a/src/main/java/org/jenkinsci/plugins/artifactdiff/ArtifactDifference.java +++ b/src/main/java/org/jenkinsci/plugins/artifactdiff/ArtifactDifference.java @@ -104,7 +104,7 @@ public String getFilename( final String artifactPath = artifact.getFile().getCanonicalPath(); - assert artifactPath.startsWith(prefix); + assert artifact.getFile().getCanonicalFile().toPath().startsWith(prefix); return artifactPath.substring(prefix.length()); }