Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in recently updated test for challenge 5. #16

Open
patnebe opened this issue Apr 12, 2020 · 10 comments
Open

Bug in recently updated test for challenge 5. #16

patnebe opened this issue Apr 12, 2020 · 10 comments

Comments

@patnebe
Copy link

patnebe commented Apr 12, 2020

image

I got the error in the screenshot above while re-running the checks about 5 - 10 minutes ago.

Could you please look into this?

Thanks in advance, and happy Easter!

@patnebe
Copy link
Author

patnebe commented Apr 12, 2020

I think something broke after the most recent pull request. This is because all the tests except the one for obtaining the logs successfully ran on my code as at 1 AM this morning.

@chalu
Copy link
Contributor

chalu commented Apr 12, 2020

Let me know if the latest patch fixed it

@chalu
Copy link
Contributor

chalu commented Apr 12, 2020

You might need to wait to review an update to the docs to get your code a pass the tests again. Minor changes to expect, since you are already here:

  • make sure you are actually logging entries and they are available at /logs
  • make sure to set the right HTTP header
  • make sure your log entries follow the right format.

@patnebe
Copy link
Author

patnebe commented Apr 12, 2020

image

Now it returns a type error. I think one of the methods within the tests is being passed the wrong type. Also, looking through PR 13 and comparing it to PR 17, I suspect the error might be within the section shown in the image below

image

@patnebe
Copy link
Author

patnebe commented Apr 12, 2020

It appears the headers and data were not extracted from the first three calls to the API so these are undefined and break things down the line.

I'm not sure but this seems like what's happening here

@chalu
Copy link
Contributor

chalu commented Apr 12, 2020

This has been fixed. Kindly confirm.

@patnebe
Copy link
Author

patnebe commented Apr 12, 2020

Great, the data extraction works now. Thank you.

The test for the logs still breaks though

image

I think this is because the randomInt method wasn't exported from the testUtils module

image

Could you please confirm & rectify this?

Thanks again.

@chalu
Copy link
Contributor

chalu commented Apr 12, 2020

The last patch should do. Let me know.

@chalu
Copy link
Contributor

chalu commented Apr 12, 2020

Thanks a million. You are a rockstar!

@patnebe
Copy link
Author

patnebe commented Apr 12, 2020

Haha you're welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants