Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View filters do not handle nulls #2042

Closed
mjashanks opened this issue Jul 21, 2021 · 2 comments · Fixed by #3104
Closed

View filters do not handle nulls #2042

mjashanks opened this issue Jul 21, 2021 · 2 comments · Fixed by #3104
Assignees
Labels
bug Something isn't working

Comments

@mjashanks
Copy link
Member

mjashanks commented Jul 21, 2021

First described in #2030.

When a column value is null (or possibly undefined ?) we cannot account for this in a view filter.

To reproduce a null value

  • Add a column of any type, when you have existing data in the table. All existing values have blank values for this column.
  • Create a new row via the builder and do not enter a value for Number or Date

Suggested solution

  • Filters should have an option for Is not set
  • When values are not set, we should explicitly say in the rows Not Set rather than having a blank cell, or unchecked box. This should probably apply to both the builder and the table component within the app
  • We could also set a "Value when not set" option on the column so that it can work nicely with formulas and view calculations.
  • For bonus points, it would be really nice to be able to run batch updates inside the builder. This has other uses, but very much a nice-to-have if the above points are covered
@stale
Copy link

stale bot commented Sep 19, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 19, 2021
@stale stale bot closed this as completed Sep 26, 2021
@shogunpurple shogunpurple reopened this Sep 27, 2021
@stale stale bot removed the stale label Sep 27, 2021
@Rory-Powell Rory-Powell self-assigned this Oct 18, 2021
@Rory-Powell
Copy link
Contributor

Changes added here #3104

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants