Typing grid clipboard store #15250
Merged
Typing grid clipboard store #15250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
aptkingston
reviewed
Dec 30, 2024
| | { | ||
| value: string | null | undefined | ||
| multiCellCopy: false | ||
| } |
There was a problem hiding this comment.
This is really cool - I didn't know you can basically conditionally type it based on the value of another field like this.
| const clipboard = writable({ | ||
| type ClipboardStoreData = | ||
| | { | ||
| value: string[][] |
There was a problem hiding this comment.
value here can be any cell value, so it doesn't need to just be a string. We could be specific about the range possible types but it can be any data type that we support, so any is probably appropriate.
There was a problem hiding this comment.
I thought that the value would always be stringified. Updated to any
aptkingston
approved these changes
Dec 31, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Typing grid clipboard store