Typing grid UI store #15249
Typing grid UI store #15249
Conversation
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
| @@ -2,6 +2,7 @@ import { UITable, UIView } from "@budibase/types" | |||
|
|
|||
| export type UIDatasource = (UITable | UIView) & { | |||
| type: string | |||
| rowHeight?: number | |||
There was a problem hiding this comment.
This is a nice find by typescript! This is supposed to be saved in the real view definition but right now it is being dropped when the grid tries to save it. So this is not intended to be a UI-only field - it's intended to be in the real ViewV2 type (but not tables as we don't allow customising row height in tables any more).
There was a problem hiding this comment.
That's true. Added the field to the doc, so it can get persisted. I don't really like that being a plain field in the view, but it works for now
There was a problem hiding this comment.
Yea agreed. Something that would probably be better suited to be inside some uiMetadata object etc, but for backwards compat we'll probably have to live with this one.
Description
Typing grid UI store