Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the rendering of the disabled setting for buttons inside the table component. #14380

Open
mikesealey opened this issue Aug 14, 2024 · 3 comments
Labels

Comments

@mikesealey
Copy link
Collaborator

Checklist

  • [Y] I have searched budibase discussions and github issues to check if my issue already exists

Hosting

  • Cloud
    • Tenant ID: andz.budibase.app

Describe the bug
Setting a button to disabled in a table does not disable the button

To Reproduce
Steps to reproduce the behavior:

  1. Add a Table component
  2. Add a button to display a notification
  3. In the button settings, check "Disabled"
  4. Pulish and click the button

Expected behavior
Disabling a button should change it's appearance and prevent it's funcitonality

Screenshots
JAM - https://jam.dev/c/a386a4e6-1e84-4f85-b076-156524a1bde4

App Export
Table Component Buttons-export-1723648046868.tar.gz

Desktop (please complete the following information):

  • OS: MacOS
  • Browser Chrome
  • Version 127.0.6533.89 (Official Build) (arm64)

Additional context
Add any other context about the problem here.

@mikesealey mikesealey added the bug Something isn't working label Aug 14, 2024
Copy link

linear bot commented Aug 14, 2024

@mikesealey
Copy link
Collaborator Author

Bonus feature request: Could we have Conditions to Update Settings for buttons in tables? Update button to be disabled if (value in row = 0)

@aptkingston
Copy link
Member

This is a known limitation I'm afraid and I think there was a ticket for it before. There are a few settings that don't have any effect for table buttons (size is another example). This is deliberate on one hand so that we can ensure that buttons actually look correct and work properly in tables, but it's also just a side effect of how we render the settings at the moment. I would flag this as an enhancement to find a different way of rendering component settings so that they can be conditional on use case.

@ConorWebb96 ConorWebb96 removed the bug Something isn't working label Aug 15, 2024
@ConorWebb96 ConorWebb96 added the enhancement New feature or request label Aug 15, 2024 — with Linear
@ConorWebb96 ConorWebb96 changed the title Table Buttons set to disabled are still enabled Change the rendering of the disabled setting for buttons inside the table component. Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants