Datasource errors blocking full creation steps #12127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lt fully - this was simply a frontend issue of the error not being handled on creation.
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## master #12127 +/- ##
=======================================
Coverage 57.36% 57.36%
=======================================
Files 259 259
Lines 7953 7953
Branches 1483 1483
=======================================
Hits 4562 4562
Misses 3107 3107
Partials 284 284 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Thank you for sorting this 🙏 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing datasource error states causing a datasource to fail to be built fully - this was simply a frontend issue of the error not being handled on creation.
Addresses: #12121 and https://linear.app/budibase/issue/BUDI-7650/if-an-external-data-source-is-added-were-any-of-the-tables-within-dont
Feature branch env
Feature Branch Link