Add camera choice option to QR scanner field #12109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added used camera preference option.
Added preferred camera setting.
Added preferred camera setting.
1 task
aptkingston
approved these changes
Oct 19, 2023
There was a problem hiding this comment.
Looks good to me! Thanks for the contribution @zedascouves.
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## master #12109 +/- ##
===========================================
- Coverage 75.74% 46.82% -28.92%
===========================================
Files 338 164 -174
Lines 14186 5811 -8375
Branches 2981 1164 -1817
===========================================
- Hits 10745 2721 -8024
+ Misses 3218 2824 -394
- Partials 223 266 +43 see 502 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
Removed quotes ("") from variable reference. I believe this is what is causing the test failure.
aptkingston
requested changes
Oct 20, 2023
Updated the code as suggested. Thanks!
zedascouves
commented
Oct 20, 2023
aptkingston
approved these changes
Oct 20, 2023
|
Do I need to do anything else for this to be successfully merged? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows selecting the camera for the QR scanner field. Issue #11459.
Addresses:
https://github.com/Budibase/budibase/issues/11459Documentation