Reply of PR[I18n support] #2573
jianzhichun
started this conversation in
Show and tell
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
According to PR I18n support
Dear @shogunpurple , I'm sorry for I have to reply on the discussion. I closed the PR because I made some commits very disrelated.
e.g. I added a new component about video and I am writting cesiumjs component for GIS or BIM show.
And what I reply to your review,
Private NPM Registry
There are a few private NPM registry references throughout this PR, and dev versions have been published to it. We would need to remove all of these, so that budibase continues to release to our public NPM repository.
I will make a pure PR.
What a pity, I did commit on the same branch.
Locale Switcher
Without using the Locale switcher, will it respect the locale of the users browser? This is important for most users.
Yes, it will. getLocaleFromNavigator() will init the locale on localStorageStore.
Once these are addressed - this is such a huge change, so it will need to go through quite a bit of testing end to end before merging.
Thanks again for taking the time to do this, we appreciate your effort and will work with you to get this merged into the platform after feedback.
Yes I will remove it.
It maybe a bugfix, I found the "api/ta_users/rows" return "missing" when there are many users above one. And I think it due to the undefined tableId of the user who isn't the creator of app
Beta Was this translation helpful? Give feedback.
All reactions