Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missed Audio Codecs on Latest Build! #138

Open
jicomy opened this issue Mar 13, 2022 · 8 comments
Open

Missed Audio Codecs on Latest Build! #138

jicomy opened this issue Mar 13, 2022 · 8 comments

Comments

@jicomy
Copy link

jicomy commented Mar 13, 2022

hello and i hope you have good time

when i downloaded latest build of https://www.gyan.dev/ffmpeg/builds/
and i checked codecs and i found out that some of audio encoder not exist in your latest build

here a list of removed/missed codec that exist in other people builds but not in BtbN build (tested on Latest Auto-Build (2022-03-13 12:33)
amr_wb Encoder
gsm Encoder
gsm_ms Encoder
ilbc Encoder
speex Encoder

@BtbN
Copy link
Owner

BtbN commented Mar 13, 2022

Are those external libraries?
Everything that has a native de/encoder in ffmpeg should be enabled by default.

@jicomy
Copy link
Author

jicomy commented Mar 13, 2022

yes, all of them using libraries, but thats not the point, because vorbis and mpeg3 using libraries too
this codecs that i reported are exist in all of other peoples builds

@BtbN
Copy link
Owner

BtbN commented Mar 13, 2022

Yes, Vorbis and mp3 are also hugely popular, while these ones are ultra rare, so it's a tradeoff between maintenance work needed, increase in binary size, and increase in attack surface.
Do you personally need any of those, or are you just comparing builds?

@jicomy
Copy link
Author

jicomy commented Mar 13, 2022

yes, i need gsm_ms one
when i change my ffmpeg.exe with this BtbN Build, i found out that something is wrong because i had it before now there is no such codec when i changed from gyan.dev build to BtbN build

@BtbN
Copy link
Owner

BtbN commented Mar 13, 2022

libgsm looks archaic, I'll see if I can get it working without too much trouble.
It's packaged in basically all distros, so there's a bunch of examples to work with.

@jicomy
Copy link
Author

jicomy commented Mar 13, 2022

its archaic, but some people, someday, at some place or corner will need them, however, if you enable all of missed libraries it will be great, because FFmpeg mainly used as an converter tool, however, it does much more
maybe there is more codecs that their encoders are available in FFmpeg but not included in any build, enabling them will be great
Thank you for Answering, Have Good time

@BtbN
Copy link
Owner

BtbN commented Mar 13, 2022

It very much depends on the library. Some of them don't play nice with modern compilers, OS, or static linking.
Or are such a huge risk that it's not worth to enable.
libgsm looks relatively fine though, just has a weird build system that needs to be dealt with somehow.

@theraininsky
Copy link

BtbN missing the following encoders:
Hap
libvo_amrwbenc
libgsm
libgsm_ms
libilbc
libshine
libspeex
While gyan missing
libopenh264
libjxl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants