Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node.js v8.3++ breaks tests #5

Closed
Bruce17 opened this issue Dec 12, 2017 · 1 comment
Closed

Node.js v8.3++ breaks tests #5

Bruce17 opened this issue Dec 12, 2017 · 1 comment
Assignees
@Bruce17 @Drexonom
Labels
bug Node.js v8.3

Comments

@Bruce17
Copy link
Owner

Bruce17 commented Dec 12, 2017

The method argList seems to break the tests (code: https://github.com/Bruce17/dependable/blob/develop/source/index.js#L416). Maybe something changed in V8 so that (function(){} ).toString() returns some strange strings.
@Bruce17
Copy link
Owner Author

Bruce17 commented Dec 12, 2017

Seems that v8 did this in previous versions:

(function(){}).tostring() // => "function (){}"

Current version:

(function(){}).tostring() // => "function(){}"

Updating the regex should solve this issue.

@Bruce17 Bruce17 mentioned this issue Dec 12, 2017
Merged
@Bruce17 Bruce17 closed this as completed Dec 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Bruce17 Bruce17

@Drexonom Drexonom

Labels
bug Node.js v8.3
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Bruce17 @Drexonom