Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Urgent fixes needed for Waterfox 56.2! Please have a look. #567

Closed
Peacock365 opened this issue May 17, 2018 · 12 comments
Closed

Urgent fixes needed for Waterfox 56.2! Please have a look. #567

Peacock365 opened this issue May 17, 2018 · 12 comments

Comments

@Peacock365
Copy link

Peacock365 commented May 17, 2018

Hey there!

So, Waterfox 56.2 is out now. Fantastic! However, there are some fixes urgently required for this version, as some features are broken without them.

  • Problem no. 1 - The "About Waterfox" window (on Mac at least)

"About Waterfox" does not display correctly on my Mac (macOS High Sierra). The window is completely white with a black ramification / frame around it. A window does open, but no actual information is displayed.

  • Problem no. 2 - The Fingerprinting changes.

I will just copy this from the gHacks user.js ver. 56, as I am not that versed with those particular settings:

/* 4702: navigator.buildID (see gecko.buildID in about:config) reveals build time

/* 4703: navigator.appName **/
// user_pref("general.appname.override", "Netscape"); // (hidden pref)
/
4704: navigator.appVersion **/
// user_pref("general.appversion.override", "5.0 (Windows)"); // (hidden pref)
/
4705: navigator.platform leaks in JS **/
// user_pref("general.platform.override", "Win32"); // (hidden pref)
/
4706: navigator.oscpu leaks in JS **/
// user_pref("general.oscpu.override", "Windows NT 6.1"); // (hidden pref)
/
4707: general.useragent.locale (related, see 0204) ***/

Just wanted to let you know.


Suggestion: Create a Waterfox 56.2.1 hotfix update that fixes these.

Thank you for your attention.

@Peacock365
Copy link
Author

Peacock365 commented May 17, 2018

Problem no. 1 could be fixed via #568

Would still need a new build to push to everyone though, and fix issue no. 2 beforehand.

@Toromino
Copy link

Toromino commented May 17, 2018

(Former) Problem no. 2 seems like, that it has already been fixed at 4368983

@Peacock365
Copy link
Author

Peacock365 commented May 17, 2018

@Toromino
Copy link

Toromino commented May 17, 2018

@Peacock365

Okay, so it is fixed, but @MrAlex94 forgot to include it in this release. So 4368983 should definitely be added to the next release!

@grahamperrin
Copy link

#538

@grahamperrin
Copy link

Problem no. 3 - The Fingerprinting changes.

@jbeich re: https://www.reddit.com/comments/8k1p3j/-/dz5cv2a/?context=1

With resistance enabled in 56.2.0 build 20180515213058, I get …/Firefox/52.0 (not 60).

$ pkg info waterfox | grep Version
Version        : 56.2.0.7

Would you like this in FreeBSD Bugzilla? Or is 52.0 expected in the FreeBSD case?

TIA

(For me personally, not urgent; I accept privacy.resistFingerprinting false.)

@jbeich
Copy link
Contributor

jbeich commented May 18, 2018

@grahamperrin, because 1ad4308 (unlike mozilla/gecko-dev@d20c7d929c84) makes less sense:

  • WF56 supports fewer APIs than ESR60 (from 57, 58, 59, 60)
  • WF56 supports fewer CSS properties than ESR60
  • RFP in WF56 has more gaps compared to ESR60 (from 57, 58, 59, 60)
  • WF56 is likely reach EOL together with ESR52

@Peacock365
Copy link
Author

Just wanted to let you all know, I have deleted the issues relating to the Sync menu iOS link and add-on compatibility, as they are fixed already and a new build can be created which will have them fixed.

I have noticed a new issue on my Mac in relation to the "About Waterfox" window. This issue is my new no.1 in my initial post. Please have a look.

@Peacock365
Copy link
Author

@jbeich:

Are you sure that Waterfox will be going EOL along with FF ESR 52? After all, Firefox 60 and Waterfox 56 are not that far apart. Wouldn't it be possible to apply most fixes, still? I understand that Waterfox 56 can't be kept up indefinitely due to web standard support, but I had at least expected it to be updated until late 2018 / early 2019... Sorry for going off-topic by the way, I am just interested in the matter.

@grahamperrin
Copy link

grahamperrin commented May 18, 2018

Thanks folks, I should steer the (non-urgent) APIs thread of this issue to:

@grahamperrin
Copy link

grahamperrin commented May 18, 2018

Problem no. 1 could be fixed via #568

Would still need a new build to push to everyone though, and fix issue no. 2 beforehand.

The numbers have changed, would you like to edit related comments? TIA.

PS ideally with strike-through markup, so that newcomers to this issue can tell what problem numbers were before and after the change.

@Peacock365
Copy link
Author

©grahamperrin:

No necessity for this, as the problems are already fixed, there is no need to further discuss them anyway. I do not intend for this issue to turn into a novel either. ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants