Site: rationalise the congratulations (whether Waterfox is truly up-to-date, and so on)

[grahamperrin]

Mozilla precedent

With user agent string

Mozilla/5.0 (X11; FreeBSD amd64; rv:56.0) Gecko/20100101 Firefox/56.0.4 Waterfox/56.0.4

https://www.mozilla.org/firefox/new/ redirects to https://www.mozilla.org/en-GB/firefox/new/ and:

Update your Firefox for the latest in speed and privacy.

… Your system may not meet the requirements for Firefox, but you can try one of these versions: …

– close enough (with FreeBSD as Tier-3, and so on).

Staging

https://staging.waterfoxproject.org/waterfox/new/ redirects to https://staging.waterfoxproject.org/en-US/waterfox/new/ and

Congrats! You’re using the latest version of Waterfox.

Good so far 👍

Then, using e.g. https://addons.mozilla.org/addon/custom-user-agent-revived/ I set this inferior user agent string for (the domain derived from) https://staging.waterfoxproject.org/:

Mozilla/5.0 (X11; FreeBSD amd64; rv:56.0) Gecko/20100101 Firefox/56.0.2 Waterfox/56.0

A reload of https://staging.waterfoxproject.org/en-US/waterfox/new/ continues to congratulate me for using latest version.

A step further back:

Mozilla/5.0 (X11; FreeBSD amd64; rv:55.0) Gecko/20100101 Firefox/55.0 Waterfox/55.0

– then another reload and again, I'm congratulated.

I'm sort of pulling those user agent strings out of a hat so I shouldn't leap to any conclusion, but the gist is:

• maybe simplest, at this time, to prune the version checking logic.

[grahamperrin]

Meta, tracking: #582

I'll probably review this issue over the weekend.