Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Often, downloading brings up the save file dialog again now #3176

Closed
1 task done
aaronliu0130 opened this issue Sep 30, 2023 · 10 comments
Closed
1 task done

Often, downloading brings up the save file dialog again now #3176

aaronliu0130 opened this issue Sep 30, 2023 · 10 comments
Labels

Comments

@aaronliu0130
Copy link
Contributor

What happened?

image
This didn't happen in G5

Reproducible?

  • I have checked that this issue cannot be reproduced on Mozilla Firefox.

Version

G6

What platform are you seeing the problem on?

Windows

Relevant log output

how do i even get logs
@MrAlex94
Copy link
Collaborator

MrAlex94 commented Oct 1, 2023

You can toggle the preference browser.download.useDownloadDir to true.

This has always been the default, except when Mozilla removed the option between 97 -> some version just before 115, before reintroducing it.

Automatically downloading files is rather user hostile and was actually the cause of a serious vulnerability in Chrome, a few years back.

@MrAlex94 MrAlex94 closed this as completed Oct 1, 2023
@aaronliu0130
Copy link
Contributor Author

aaronliu0130 commented Oct 1, 2023

Sure. I'd heavily prefer to have this sort of stuff in changelogs though. The UI also looks quite a bit outdated and there's no corresponding pref (about:preferences) but that's just a nit.

BTW I think this should be closed as not planned.

@aaronliu0130
Copy link
Contributor Author

@MrAlex94 I've toggled the config and restarted Waterfox but it still prompts.
image
image

@MrAlex94
Copy link
Collaborator

MrAlex94 commented Oct 1, 2023

These are all the related prefs I've changed by default:

// PREF: Enforce user interaction for security by always asking where to download
// [SETTING] General>Downloads>Always ask you where to save files
// false=the user is asked what to do
pref("browser.download.useDownloadDir", false);

// PREF: disable downloads panel opening on every download
pref("browser.download.alwaysOpenPanel", false);

// PREF: Disable adding downloads to the system's "recent documents" list
pref("browser.download.manager.addToRecentDocs", false);

// PREF: enable user interaction for security by always asking how to handle new mimetypes
// [SETTING] General>Files and Applications>What should Firefox do with other files
pref("browser.download.always_ask_before_handling_new_types", true);

// PREF: autohide the downloads button
pref("browser.download.autohideButton", false);

// PREF: open PDFs inline (FF103+)
pref("browser.download.open_pdf_attachments_inline", true);

Although odd that the pref you've toggle hasn't changed anything. Is that including after a restart?

@MrAlex94 MrAlex94 closed this as not planned Won't fix, can't repro, duplicate, stale Oct 1, 2023
@aaronliu0130
Copy link
Contributor Author

aaronliu0130 commented Oct 1, 2023

I tried restarting waterfox, yes. I'll try restarting my PC after this match

@aaronliu0130
Copy link
Contributor Author

Restarting my PC doesn't work either

@thunderstone135
Copy link

Try setting browser.download.dir to C:\Users\<UserName>\Downloads.
is your Windows Profile Name. You can use other directories if you want.

@aaronliu0130
Copy link
Contributor Author

I already have that config. Set it again for good measure. Still doesn't work.

@thunderstone135
Copy link

In about:preferences 👇

Imgur
Is this option checked?

Imgur
Which option is selected?

@aaronliu0130
Copy link
Contributor Author

aaronliu0130 commented Oct 3, 2023

@thunderstone135 Changing the second pref you sent did it, thanks!

@MrAlex94 I still think this and a way to revert should be mentioned in changelogs. I also disagree with not making the downloads panel open, it's not very intrusive and is more noticeable than the download icon changing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants