Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential renaming of remote branches on 4th October. #1179

Closed
MrAlex94 opened this issue Oct 2, 2019 · 8 comments
Closed

Potential renaming of remote branches on 4th October. #1179

MrAlex94 opened this issue Oct 2, 2019 · 8 comments

Comments

@MrAlex94
Copy link
Collaborator

MrAlex94 commented Oct 2, 2019

I am planning to rename the remote branches of the Waterfox repository as follows:

master ➡️ classic
gecko68 ➡️ current

current will then become the default branch.

@Peacock365, @hawkeye116477, @laniakea64, @grahamperrin I have tagged you all as you frequently submit pull requests to Waterfox.

Are you all okay with this rename, or is there any potential apprehension towards this change?

@MrAlex94 MrAlex94 pinned this issue Oct 2, 2019
@MrAlex94 MrAlex94 changed the title Potential renaming of branches on 4th October. Potential renaming of remote branches on 4th October. Oct 2, 2019
@laniakea64
Copy link

Fine with me.

@hawkeye116477
Copy link
Contributor

hawkeye116477 commented Oct 2, 2019

Ok, no problem.

@grahamperrin
Copy link

Thanks … reading this alongside https://github.com/MrAlex94/Waterfox/wiki/Versioning-Guidelines#addition-of-channels

I don't know git or GitHub in any depth but FWIW I don't foresee a problem.

AFAIR my old fork of master contains nothing significant, I guess that in due course I can/should delete it (if/when I fork one or both of the new branches).

A quick search with Bing found things such as these, quite old but I guess that least one might be relevant for one of us:

@grahamperrin
Copy link

Branch changes: git clone, building etc. : waterfox – a couple of questions (this is all new territory for me).

@grahamperrin
Copy link

https://github.com/MrAlex94/Waterfox/wiki/Quick-Build#build-configuration

… By default, the build system creates a release build of Waterfox for Windows. …

I guess, that should change to:

… By default, the build system creates a release build of Waterfox Current for Windows. …

Nit (at the same page): https://github.com/MrAlex94/Waterfox/wiki/Quick-Build#mac-os-x-mozconfig an outdated use of org.Waterfoxproject

@grahamperrin
Copy link

classic f5c1f61#diff-0d831f716913d38bb39bcf7c35e1be7cR1 will 2019.10 be both the displayed version and the tag?

@MrAlex94
Copy link
Collaborator Author

Yes that's correct.

@MrAlex94 MrAlex94 unpinned this issue Oct 16, 2019
@grahamperrin
Copy link

A minor issue, half-expected:

  • external references to e.g. master no longer work.

Only half-expected, because I imagined that GitHub might automatically redirect in cases such as this:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants