Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v68: Expose privacy.firstparty.isolate.block_post_message in about:config by default #1081

Closed
laniakea64 opened this issue Jul 25, 2019 · 2 comments · Fixed by #1305
Closed

Comments

@laniakea64
Copy link

https://github.com/MrAlex94/Waterfox/blob/f8a37ef0e898f9199f050559ac6bdf931b35a93d/caps/OriginAttributes.h#L95-L99

https://github.com/MrAlex94/Waterfox/blob/f8a37ef0e898f9199f050559ac6bdf931b35a93d/caps/OriginAttributes.cpp#L34-L36

This boolean pref is not visible in about:config by default. I think it was added in Mozilla bug 1492607, and I don't see any rationale there for why it's completely hidden. It sounds like it could be an interesting security option, so should Waterfox expose this pref in about:config by default?

To be clear, I think Waterfox should leave the default value of this pref as-is. From this line...
https://github.com/MrAlex94/Waterfox/blob/f8a37ef0e898f9199f050559ac6bdf931b35a93d/caps/OriginAttributes.cpp#L22
... and comments in the Mozilla bug, I believe its default value is false, but I'm not 100% sure, so didn't submit a pull request.

@grahamperrin
Copy link

… I don't see any rationale there for why it's completely hidden. …

https://www.reddit.com/r/firefox/comments/ciev66/-/ev4njjg/ maybe

@laniakea64
Copy link
Author

I believe its default value is false, but I'm not 100% sure, so didn't submit a pull request.

Ok, looking also at the code for the related tests makes it even clearer that this pref defaults to false -
https://github.com/MrAlex94/Waterfox/blob/19fe621225c69b3a8df8f60cc5d68bd0422601e4/browser/components/originattributes/test/browser/browser_postMessage.js#L94-L110

FWIW, I've now had this feature enabled in my daily-use Waterfox profile for a while, and I haven't noticed any issues from it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants