Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated spatial validation to use UK Offshore Area #102

Closed
KoalaGeo opened this issue Apr 19, 2023 · 0 comments · Fixed by #117
Closed

Updated spatial validation to use UK Offshore Area #102

KoalaGeo opened this issue Apr 19, 2023 · 0 comments · Fixed by #117

Comments

@KoalaGeo
Copy link
Collaborator

KoalaGeo commented Apr 19, 2023

More geotechnical investigations are occurring offshore & therefore BGS will receive submissions of this data.

We currently use the UK coastline as one of the validation checks (https://github.com/BritishGeologicalSurvey/pyagsapi/blob/main/app/gb_outline.geojson).

This should be swapped for the UK offshore eea (https://github.com/BritishGeologicalSurvey/pyagsapi/blob/main/app/uk_eea_area_ex_ni.geojson)

We do need to maintain the Onshore NI checks (https://github.com/BritishGeologicalSurvey/pyagsapi/blob/main/app/ni_outline.geojson).

Logic:

If outside EEA & NI then EEA error/warning
ELSE same checks as currently

Deprecate Bounding Box Check - EEA performs same function

Tests:
Edinburgh = No error
Dogger Bank = GB Error so Offshore
Belfast with LOCA_GREF = No error
Belfast without LOCA_GREF = LOCA_GREF undefined
Kenya = Outside EEA error

@KoalaGeo KoalaGeo mentioned this issue May 9, 2023
19 tasks
@KoalaGeo KoalaGeo linked a pull request Jul 13, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant