Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make OracleDbHelper.get_sqlalchemy_connection_string use oracle+oracledb instead of oracle #215

Closed
1 task done
leorudczenko opened this issue Nov 8, 2024 · 0 comments · Fixed by #217
Closed
1 task done

Comments

@leorudczenko
Copy link
Collaborator

leorudczenko commented Nov 8, 2024

Summary

When etlhelper was updated to v1.0.0, one of the major changes was replacing the use of cx_Oracle with oracledb. This is great, but the method OracleDbHelper.get_sqlalchemy_connection_string was not updated to reflect this change.

On this line, the string begins with oracle://, which will default to oracle+cx_oracle://, which is now deprecated in etlhelper.

Solution

To explicitly use oracledb, the connection string must start with oracle+oracledb:// instead. This was found from a stackoverflow post here, with a link to the official documentation on this being here.

Acceptance Criteria

  • oracle:// is replaced with oracle+oracledb:// in the method OracleDbHelper.get_sqlalchemy_connection_string
@leorudczenko leorudczenko changed the title Make get_sqlalchemy_connection_string use 'oracle+oracledb' instead of 'oracle' Make OracleDbHelper.get_sqlalchemy_connection_string use oracle+oracledb instead of oracle Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant