Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MS SQL server driver and test configuration #175

Open
4 tasks
volcan01010 opened this issue Aug 16, 2023 · 2 comments
Open
4 tasks

Update MS SQL server driver and test configuration #175

volcan01010 opened this issue Aug 16, 2023 · 2 comments
Assignees

Comments

@volcan01010
Copy link
Collaborator

Summary

As an etlhelper developer, I would like to update the MS SQL Server configuration so that the tests will pass.

Description

Since the MS SQL Server connection configuration was first developed, a few things have changed:

  • We are going to switch to a new Docker base image file, based on Debian 11 (Bullseye). The current Docker build install the msodbc driver for Debian 9. The build should be updated to use the new version.
  • The MS ODBC driver has moved on to version 18 (for the tests, this is configured in an environment variable and is currently set to 17)
  • The MS ODBC version 18 driver throws an exception if the target database has a self-signed certificate

All of these changes have resulted in the test suite failing for MS SQL Server. It should be fixed for v1 of etlhelper.

Acceptance criteria

  • Dockerfile uses later MS ODBC driver (version 18)
  • Test configuration specifies version 18 of driver
  • Test configuration allows self-signed certificates
  • Integration tests for MS SQL all pass
@volcan01010
Copy link
Collaborator Author

@volcan01010
Copy link
Collaborator Author

These commits, now in v1 are related.

This one adds a trust_server_certificate flag to MSSQL server connections so it can cope with our self-signed test server.

24fc90b

We should probably add a flag for encrypt, as that was also changed in SQL server 18 driver.

This one adds a new error message because the default dictionary row factory isn't compatible with pyodbc's named placeholders. 868ceda

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants