-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch to GitHub actions #36
Conversation
import '@brightspace-ui/core/components/colors/colors.js'; | ||
import '@brightspace-ui/core/components/dropdown/dropdown-content.js'; | ||
import '@brightspace-ui/core/components/dropdown/dropdown.js'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seemed like an easy fix to do at the same time -- these are directly aliased from those old d2l-dropdown files.
on: | ||
push: | ||
branches: | ||
- master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this have the other branches because it does publish to npm (I think I missed this in another PR today...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't been adding it for anything except core and Intl. I think it'll be suuuuuuper rare to ever care about release branches for these. I figure we can always add that support later? 🤷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah it's probably not common, I've had to do it a few times for facet-filter-sort but it doesn't publish to npm yet. I think it depends how active development is on a labs component. But we can definitely always add it later
🎉 This PR is included in version 2.0.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
No description provided.