Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to GitHub actions #36

Merged
merged 2 commits into from
Nov 20, 2020
Merged

switch to GitHub actions #36

merged 2 commits into from
Nov 20, 2020

Conversation

dlockhart
Copy link
Contributor

No description provided.

import '@brightspace-ui/core/components/colors/colors.js';
import '@brightspace-ui/core/components/dropdown/dropdown-content.js';
import '@brightspace-ui/core/components/dropdown/dropdown.js';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seemed like an easy fix to do at the same time -- these are directly aliased from those old d2l-dropdown files.

on:
push:
branches:
- master
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this have the other branches because it does publish to npm (I think I missed this in another PR today...)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't been adding it for anything except core and Intl. I think it'll be suuuuuuper rare to ever care about release branches for these. I figure we can always add that support later? 🤷

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it's probably not common, I've had to do it a few times for facet-filter-sort but it doesn't publish to npm yet. I think it depends how active development is on a labs component. But we can definitely always add it later

@dlockhart dlockhart merged commit 5f03861 into master Nov 20, 2020
@dlockhart dlockhart deleted the gha branch November 20, 2020 20:50
@ghost
Copy link

ghost commented Nov 20, 2020

🎉 This PR is included in version 2.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ghost ghost added the released label Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants