Create instance own localize method #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well I'll be! Getting difference benchmark results today, showing Edit: My laptop battery was just dying and affecting the results. Plugged it in and they're all basically the same within well below 1% |
dlockhart
reviewed
Nov 12, 2024
| @@ -214,6 +214,7 @@ export const Localize = class extends getLocalizeClass() { | |||
| constructor(config) { | |||
| super(); | |||
| super.constructor.setLocalizeMarkup(localizeMarkup); | |||
| this.localize = (...args) => super.localize(...args); | |||
There was a problem hiding this comment.
Haha really that was it?! 💯 Is there a way to have a test that would have failed before when they were sharing resources but now passes?
dlockhart
approved these changes
Nov 13, 2024
|
🎉 This PR is included in version 3.19.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each instance of the
Localizeclass should have its own (as inhasOwn)localizemethod to store its resources and other localization-related state.This is not applied to the
LocalizeClassso that other uses, like for component mixins, can continue to share resources per-component. There is some light additional work to be done incoreto fully take advantage of this because it's currently re-fetching for each element even if the component has its resources. However, that can be done separately from this change.Using
getPrototypeOf/superinstead ofbindhas the advantage of keeping the sharedlocalizemethod and not hogging memory, with no hit to speed.