-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: CodeArtifact Migration - Phase 1 #74
Conversation
"dependencies": { | ||
"@polymer/polymer": "^3.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is used by one of the source files, so moving it out of dev-dependencies
.
// Disable URLSearchParams until they are fully supported (i.e. Edge) | ||
// Disable URLSearchParams until they are fully supported (i.e. Edge) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linting demanded this be indented 🤷♀️
Looks like git thinks the test files are too different to show a clean diff - none of the tests have changed, just updated linting and using the new helper libraries to remove the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job cleaning this up, I'm sure it'll save us time down the road!
🎉 This PR is included in version 1.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This PR updates all the ci tech (Travis -> GitHub Actions, update linting, update test runner, add semantic-release) and does Phase 1 of the CodeArtifact migration.
Phase 1:
publishConfig
andfiles
topackage.json
release.yml
workflow accordingly (will vary depending on release action used)Releases
section to mention it publishes tonpm