Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: CodeArtifact Migration - Phase 1 #74

Merged
merged 2 commits into from
Jun 2, 2022
Merged

Conversation

svanherk
Copy link
Contributor

@svanherk svanherk commented Jun 2, 2022

This PR updates all the ci tech (Travis -> GitHub Actions, update linting, update test runner, add semantic-release) and does Phase 1 of the CodeArtifact migration.

Phase 1:

  • Publish to npm
    • Change the name to the new name (found in spreadsheet)
    • Add publishConfig and files to package.json
    • Update the release.yml workflow accordingly (will vary depending on release action used)
  • Update README
    • Update install instructions and paths if name changed
    • Update Releases section to mention it publishes to npm

@svanherk svanherk requested a review from dlockhart June 2, 2022 13:01
"dependencies": {
"@polymer/polymer": "^3.0.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is used by one of the source files, so moving it out of dev-dependencies.

// Disable URLSearchParams until they are fully supported (i.e. Edge)
// Disable URLSearchParams until they are fully supported (i.e. Edge)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linting demanded this be indented 🤷‍♀️

@svanherk
Copy link
Contributor Author

svanherk commented Jun 2, 2022

Looks like git thinks the test files are too different to show a clean diff - none of the tests have changed, just updated linting and using the new helper libraries to remove the html file.

Copy link
Member

@dlockhart dlockhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job cleaning this up, I'm sure it'll save us time down the road!

@svanherk svanherk merged commit b6acd40 into main Jun 2, 2022
@svanherk svanherk deleted the codeartifact-phase-1 branch June 2, 2022 16:55
@ghost
Copy link

ghost commented Jun 2, 2022

🎉 This PR is included in version 1.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ghost ghost added the released label Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants