Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Object curly spacing #35

Merged
merged 4 commits into from
Aug 14, 2020
Merged

Object curly spacing #35

merged 4 commits into from
Aug 14, 2020

Conversation

chrisd2l
Copy link
Contributor

Added object-curly-spacing

This rule enforces consistent spacing inside braces of object literals, destructuring assignments, and import/export specifiers.

dlockhart
dlockhart reviewed Aug 14, 2020
View reviewed changes
Copy link
Member

@dlockhart dlockhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed with Gaudi and we're good with this change -- thanks for adding it! A couple comments to address and then it's good to go.

package.json Outdated Show resolved Hide resolved
common-config.js Outdated Show resolved Hide resolved
@dlockhart dlockhart merged commit bb870d7 into Brightspace:master Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlockhart dlockhart dlockhart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrisd2l @dlockhart